Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option for viewing sr decks and cards in tabs #1169

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

KyleKlus
Copy link
Contributor

@KyleKlus KyleKlus commented Nov 17, 2024

This pr implements the ability to open the views (deck view and card view) of the sr plugin in a tab/window, rather than in a modal. This ability is turned off by default and can be turned on via a toggle in the ui settings of the sr plugin.
Further more one can also limit the size of the ui within a tab via the already existing flashcard size setting.

This should also satisfy the issues #819 and #950.

image
The deck list in a tab

image
A card in a tab

image
New setting in the "User Interface" tab

@KyleKlus KyleKlus changed the title [FEAT]: Tabbed view feat: Option for viewing plugin in tabs Nov 17, 2024
@KyleKlus
Copy link
Contributor Author

KyleKlus commented Nov 17, 2024

Hi, sadly I cant get the import sorting to work, as the formatter doesnt fix any sorting issues for me.
It would be great if you could help me with these errors, as I dont know how to fix these (@st3v3nmw or @ronzulu ).

@KyleKlus KyleKlus changed the title feat: Option for viewing plugin in tabs feat: Option for viewing sr decks and cards in tabs Nov 20, 2024
@KyleKlus
Copy link
Contributor Author

Please dont merge it just yet; I have discovered, that the button alignment breaks, if one tilts the phone into horizontal mode 😅

@KyleKlus KyleKlus marked this pull request as draft November 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant